Implement git refs #79
Conversation
Co-authored-by: Yevgeniy Brikman <[email protected]>
``` $ go build . && ./fetch --repo=https://github.com/pete0emerson/demo --ref=banana demo Downloading git reference "banana" of https://github.com/pete0emerson/demo ... Extracting files from <repo>/ to demo ... 2 files extracted Download and file extraction complete. ``` Note that this doesn't do any testing yet (booo). It also doesn't consider the parsing of the ref for a potential tag constraint.
pete0emerson
changed the title
|
This closes #73 |
There was a problem hiding this comment.
Overall this LGTM! The docs are clear, the tests cases seem sufficient, and the implementation looks clean. I'm not a CODEOWNER on this repo and I haven't contributed to this project before, so I'll defer the approval to one of the CODEOWNERs.
My only open question though is this: it seems like--ref supersedes --tag, --branch, and --commit, so why keep those flags around?
The only reason for keeping the other flags around is for backwards compatibility. Once any uses of it are moved over to |
|
Looks good & easy to understand! |
This closes #73
This implements a
--refflag which can be used instead of--tag,--branch, or--commit.